feat: make more commands exit select mode #8689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think in general if we're making edits then we should exit select mode (also see #3932 (comment), and never mind #3932 (comment) - I've changed my mind since then). Having paste exit select mode definitely makes sense since we already exit select mode on replace. |
|
I see, that makes sense, thanks! In that case, I think some other good candidates along with paste could be |
rmehri01
changed the title
kirawi
added
S-waiting-on-review
archseer
approved these changes
Nov 18, 2023
the-mikedavis
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8687
The issue also mentioned that paste exits select mode but I don't think that is the case, only replace seems to. Should we also add exiting select mode to paste or any other commands?